Fair Allocation
Maintained by
Learnweb – University of Münster, Daniel Meißner
This Module lets you add an activity to courses, in which users can rate choices. You may then distribute the users fairly to the choices by maximizing overall 'happiness' in terms of ratings.
This may be an alternative to the choice activity or first-come-first-served.
Comments
Comments are no longer open for new posts. Existing comments remain available to read.
Plugin check resultsHelp with Plugin check results
Recommended Provide the plugin descriptionHelp with Provide the plugin description
Recommended Provide bug tracker URLHelp with Provide bug tracker URL
Recommended Provide the source control URLHelp with Provide the source control URL
Suggested Provide the external documentation URLHelp with Provide the external documentation URL
For some reason it appears that the copyright notices are still not showing your name in the following files.
./db/upgrade.php: * @copyright 2011 Your Name
./grade.php: * @copyright 2011 Your Name
./index.php: * @copyright 2011 Your Name
I am going to go ahead and approve this and see if I can add in the German language file as it has been some time since I have looked at AMOS. Please do not hesitate to let me know if there is anything I can do to be supportive of your efforts. Peace - Anthony
thanks your feedback.
I changed the redirect.
I modified the copyright information.
I deleted the german translation, however it seems I can only do the translations in ATMOS as soon as the plugin gets published, right?
I knew about the code-checker plugin and it terminated without errors, only notices, did you notice anything in particular?
You will want to require the students to make some positive ratings (at least one...) because distribution otherwise becomes impossible. It is generally not important how many 'positive' respones you get.
Please have another look at it,
Thanks - Max
You should really redirect before you start page output
line 758 of /lib/outputrenderers.php: call to debugging()
line 2591 of /lib/weblib.php: call to core_renderer->redirect_message()
line 295 of /mod/ratingallocate/locallib.php: call to redirect()
line 54 of /mod/ratingallocate/view.php: call to ratingallocate->handle_view()
In addition, it is recommended that the plugin only contain the English language pack and then use AMOS to add the German language pack.
I noticed some of the files did not have your name listed in the copyright so you may want to patch those up when you get a chance.
./db/log.php: * @copyright 2011 Your Name ./db/upgrade.php: * @copyright 2011 Your Name
./db/access.php: * @copyright 2011 Your Name
./db/install.php: * @copyright 2011 Your Name ./db/uninstall.php: * @copyright 2011 Your Name
Overall, thing seem reasonably functional. One question I had as I worked with it was why only limit the number of times that someone can respond no? I suspect teachers may want to be able to limit the number of yes and/or maybe response as well. I suspect that the rationale for this is related to the impact that those negative responses have on the calculations.
It is encouraged to follow Moodle’s coding style as outlined in: http://docs.moodle.org/dev/Coding_style and http://docs.moodle.org/dev/Coding The code checker plugin can be quite helpful in fine tuning your code and can be found at: https://moodle.org/plugins/view.php?plugin=local_codechecker You may wish to consider using that tool to further improve your plugin. Here are the results from an initial check - most of the issues seem to be with spacing so nothing that would prevent approval in terms of code.
For now, I am going to mark this as needing more work to give you a chance to clean up the copyright information and remove the de folder from the lang folder and perhaps address the other issues as best as possible. Peace - Anthony