Checkmark report
Maintained by
AMC Academic Moodle Cooperation
The Checkmark Report provides teachers and students with an overview of the details of all checkmark activites in a course. In this way, ticks, grades, feedback and other key figures can be displayed in a compact form and exported in various formats.
Comments
Comments are no longer open for new posts. Existing comments remain available to read.
Thanks Kasia for providing the new version of the plugin. I was able to successfully test the functionality and I did not spot any apparent blockers while reviewing the code. The code looks sane and is easy to follow. I left just one easy-to-fix issue in your tracker for you. You are cleared to land now, welcome to the Plugins directory!
We will try to fix your reported issues asap and will add a new version as soon as we have a stable branch with the fixed issues.
Cheers Kasia
-Katarzyna Potocka-
Additionally, some notes from a quick look at this plugin's code that you may want to fix before resubmitting:
* styles.css - see the CSS styles section at https://docs.moodle.org/dev/Plugin_contribution_checklist#Coding - selectors like `span.downloadlink` are likely to affect UI elements outside your plugin scope (note that all CSS files from all plugins are concatenated and served to browsers in a bulk, thence proper naming is crucial
* Your plugin could profit from https://docs.moodle.org/dev/Automatic_class_loading in a way that would make you to implicitly use the correct classes names (with correct prefix). Classes with name like `checkmarkreport` conceptually belongs to a hypothetical mod_checkmarkreport, they should start with `local_checkmarkreport` prefix.
* I can you are using the new events system instead of the legacy add_to_log() calls. As far as I know, this change makes the db/log.php obsolete and it should be removed. It is also preferred to remove the empty files that do not do anything like your current db/install.php.
Really looking forward to test the functionality of both plugins. Please do not forget to use "Add a new version" button to upload new versions of both plugins prior to scheduling them for re-approval.
Thanks for your patience with the review and approval process.
http://integration.moodle.org/job/Precheck%20remote%20branch/11884/artifact/work/smurf.html