Exabis Student Review icon

Exabis Student Review

Maintained by Andreas Riepl
Empowering Educators for Periodic Student Assessments #competencies #personalisation #reports
Price option: Free

Supports Moodle 2.0-5.2 See all versions
Latest release: 2 weeks ago
Installations: 208
Downloads (last 90 days): 117

Frankenstyle name: block_exastud
Blocks

Comments

Comments are no longer open for new posts. Existing comments remain available to read.

Hi Andreas,
I was translating the Exabis Student Review plugin in AMOS and I noticed a strange-looking English language string:
2.5 [errorstarttimebeforeendtime,block_exastud]
Period {$a->description} has its starttime before its endtime!
Maybe I am wrong, but the start_time must always be before the end_time, and the error is just the opposite.
Or could it be that this plugin checks from (let's say, today=start_time) to a given moment in the past (end_time) ?
Could you please check this, as I am not a native English speaker.
Thanks in advance for your help.
Andreas - Thanks for cleaning up the README.txt. I see that you added the addinstance capability. The copyright holder still seems to be a bunch of initial and is not really clear but I will leave that up to you. It does not appear that there are any settings so it looks like your removed the config_global.html file which is fine. One small thing I noticed while installing and poking around was:
Invalid get_string() identifier: 'commentshouldnotbeempty' or component 'block_exaport'. Perhaps you are missing $string['commentshouldnotbeempty'] = ''; in /m24/blocks/exaport/lang/en/block_exaport.php?
The code you have in the picture_upload_form.php file is:
get_string("commentshouldnotbeempty", "block_exaport")
I'm not sure what the reference to block_exaport is - is that a separate block? If so, it is not listed as a dependency in the version.php. Otherwise, the string is missing in the lang file. In any case, this is a smaller issues and not likely to hold up approving the block. If the block does have dependencies then we should probably create a set.
Peace - Anthony
I've gone ahead and approved the plugin. When you have a moment, it would be helpful to provide a tracker url to the Useful links section. Even if there is no dependency, we can still create a set of plugins that are best installed together (for example exaport). Peace - Anthony
fyi - the recommended (but not required) repository name would be moodle-block_exastud
One more thing I discovered, "This block still uses an old-style config_global.html file. It must be updated by a developer to use a settings.php file" please make that fix so the block is 2.x compatible. Peace - Anthony
FYI, during the plugin review In Moodle 2.4 I noticed the following: The block exastud does not define the standard capability block/exastud:addinstance Peace - Anthony