Course Request Manager

I would appreciate if the enrolment key were optional, so that the administrator could select side-wide that no enrolment key is requested. This would work better for our local installation...

I have posted a suggestion on github for changes in block_cmanager.php

I'm having some difficulties with visual styles of this plugin/block. I use Moodle 2.5 with Splash theme. In the block, the images are referenced directly following a certain assumption of plug-in location. Ex.: "../blocks/cmanager/icons/make_req.ico" In my case, I get an X. Could it be possible to modify the block and use image.php to get the files?

Kyle, for what it's worth my patches were against moodle 2.4. I haven't tried the module yet with 2.5, we are waiting to upgrade until next term. Thanks.
Josh

Thank you @Josh for the update!
In Moodle 2.5 a new field had been added called "customint6", this cause some issues with CRM, as before this it did not exist!
A new version of CRM is available now resolving the self enrollment issues!
Thank you,
Kyle.

Thanks @Kyle Goslin - that worked, though I had to dump the cmanager tables and re-import them after the new version installed. I was hoping it would fix an issue I'm having. If I have this Admin setting enabled:
Site Administration -> Plugins -> Enrolments -> Self enrolment -> Add instance to new courses
Then there is a bug in that the user provided enrollment key is not shown on the course edit page. The reason is that when the new course is created it adds a self-enrollmnet method automatically with a random key. When CRM adds it's self-enrollment method with the key provided by the user, it is not first in the default sort order so it is effectively hidden. I worked around this by adding this hack code to lib/course_lib.php before you call $DB->insert_record('enrol', $enrollmentRecord);
// disable all other existing self enrol methods, including any auto generated when
// new course created due to the "Add instance to new courses" setting being enabled for self enrollments.
// This way the new record added below will be the active one.
$rs = $DB->get_recordset('enrol', array('enrol' => 'self', 'courseid' => $nid));
foreach ($rs as $self_enrol) {
$DB->update_record('enrol', array('id' => $self_enrol->id, 'status' => 1));
}
$rs->close();
It would be nice if CRM could handle this situation. Let me know if you have any questions about the issue or if you prefer a bud filed.
Josh

@Chris if you can send over a URL to the image (the URL thats now showing, I can take a look!)

just installed on 2.5 any reason the images dont display on the block- I havnt changed any settings yet.

@Josh The minimum required Moodle was made lower, and moodle seems to handle it funny, If you remove the older version of CRM (the one from the blocks admin page) and then add the new one, this problem should be resolved.

Anyone else get this error when they attempt to upgrade database?
Cannot downgrade block_cmanager from 2013041131 to 2013041131.
Debug info:
Error code: cannotdowngrade
Stack trace: ◦line 258 of /lib/upgradelib.php: downgrade_exception thrown
◦line 30 of /blocks/cmanager/db/upgrade.php: call to upgrade_block_savepoint()
◦line 813 of /lib/upgradelib.php: call to xmldb_block_cmanager_upgrade()
◦line 362 of /lib/upgradelib.php: call to upgrade_plugins_blocks()
◦line 1544 of /lib/upgradelib.php: call to upgrade_plugins()
◦line 349 of /admin/index.php: call to upgrade_noncore()

@ross anderson - This has been fixed and will be in the next release. Thank you for the feedback!

@John Keisers - thank you for the comments regarding the escaping. This has been fixed and will be in the next release!

Ive just installed this on a standard 2.5 install with the 'Clean' theme. Just about everything works fine apart from the form fields on Page 2 of the request form. Every time i add a new field, type in the name and click save it asks me to either 'stay on page' or 'leave the page'. Whichever one i click it wipes the name out of the field. Ive tried this on chrome, Firefox and Safari all on the Mac. Also tried on an ipad but doesn't save the field. Any ideas?

There seems to be an issue with escaping the values of items added to drop-down lists in the forms. I had to escape the apostrophe chaacter using the numeric character reference.

Fields sdded to the form after the initial form creation end up on top of the page. In course-new.php, the query
$formFields = $DB->get_records('block_cmanager_formfields',array('formid'=>$formId));
should be:
$formFields = $DB->get_records('block_cmanager_formfields', array('formid'=>$formId), $sort='position ASC');
Thank you.