BTEC marking
Maintained by
Marcus Green
BTEC grading for Pass, Merit and Distinction assignments.
Comments
Comments are no longer open for new posts. Existing comments remain available to read.
Please can we have this plugin for 2.8?
Thanks
p.s. Yes, it is known that some plugin types still need to be fixed so they can be fully uninstalled. Thanks for reminding that. Hopefully there will some time available soon to work on it.
https://moodle.org/mod/forum/discuss.php?d=254395
methods API, I was particularly interested in your plugin.
Firstly, please make sure that your plugin version has appropriate Moodle version(s) selected at the 'Supported software' section of
the version form. Without it, your plugin can't be fully integrated into the overall infrastructure of the automatic plugin
installation and update. Thanks.
I realized the BTEC scale created during the installation has hardcoded English strings. Did you consider using the site default
language instead? And is it possible to change the scale description (or replace it with a new one) once the method is installed?
Also, some of your strings seem to relay on leading and trailing whitespace. Note that it's not supported by Moodle localisation
tools and people might be unable to get the whitespace into non-English strings. Also, all those strings used in $componentlist are
not defined. What's the purpose for them?
I noticed that some of the copyrights still reference author of the original gradingform you used as the template. It is preferred
that all of the files that you have modified for this plugin have your name added as a copyright holder, or (if there is no real
code re-used such as in your string files), contain just your name.
Please note that your plugin defines some constants (such as REFER) and functions (such as list_of_components()) in the global
namespace without proper frankenstyle prefix. This is serious as it may collide with other core code and/or another plugin in the
future. Please avoid that by either using frankenstyle prefix or wrapping your constants and function in a class (e.g.
gradingform_btec_controller::REFER and public static gradingform_btec_controller::components()).
I must admit it took me some time to fully understand the overall logic of the grading. Maybe it is worth of providing more
real-life examples in the documentation. I believe it would help your users to have clearer idea on how to use this method. Thanks
for providing the unit tests. Grades calculation is essential part of any reliable LMS and it's good to see you seem to agree with
that.
For now, I am going to mark this plugin as needing more work until we get these issues resolved. Thanks for your patience with the
review and approval process.