eledia webservicesuite

p.s. - you may also want to show a screenshot of admin/webservice/documentation.php

Thanks for responding to the feedback and providing the meta-data for the plugin. I re-tested the plugin and test token is now properly stored in config_plugins. I am going to go ahead and approve this plugin. Peace -Anthony

MDLSITE-2997, it should work now

I have got a problem with the plugin page here. When i try to edit the plugin i can not save it. Even saving the form without any changes lead to a "error/unknownparamtype" error.

Hallo Anthony,
first thank you for your fast reaction. I will add the Description, tracker and documentation URLs as soon as i find the time for it. We are a bit in a rush here because of the german MoodleMoot tomorrow.
The setting should be stored in the plugins. So this one is a real bug and i will change that.
The function you find out to be duplicate are marked as DEPRECATED within their Description, with the hint to use the new core functions. I don't want to remove them now, because some of our customers may use them at the moment. It's similar to the old functions in core which still are there with the DEPRECATED notice.

I am going to check with Jerome, but am curious about avoiding duplication with functions (webservices) that are already in core. For example, using core_user_get_users_by_field instead of elediaservice_get_user_by_mail or elediaservice_get_users_by_idnumber. It may also be good for him to see what are introducing should some of the functionality prove desirable for core.

Just to be clear, I think it would help for folks to have this list of additional services visible to them before installing the plugin:
elediaservice_course_completion
elediaservice_enrol_users_by_idnumber
elediaservice_get_courses_by_idnumber
elediaservice_get_user_by_idnumber
elediaservice_get_user_by_mail
elediaservice_get_users_by_idnumber
elediaservice_unenrol_users_by_idnumber
elediaservice_update_courses_by_idnumber
elediaservice_update_users_by_idnumber
Once installed, I appreciated that they appear with the other webservices

Benjamin - Many thanks for sharing this plugin with the Moodle community. Please review http://docs.moodle.org/dev/Plugin_validation#Recommended_URLs and provide tracker and documentation URLs.
With settings.php, you are storing the plugins' test_token setting in $CFG rather than using $get_config which is what I would recommend for plugins.
I think it would be helpful to provide a list of the additional webservices either in the longer description or in the documentation.
For now, I am going to mark this as needing more work but feel free to use the comments here to discuss any issues or ask any questions about the plugin entry. You can upload the revised version when ready and then schedule the plugin to reviewed again. Thanks for your patience with the plugin approval process.
Peace - Anthony