Grouptool
Maintained by
AMC Academic Moodle Cooperation
With the Grouptool activity, teachers can create groups and give students the opportunity to register and deregister for these groups independently or, if necessary, to register for waiting lists.
Comments
Comments are no longer open for new posts. Existing comments remain available to read.
For the record, the troubles with uploading a new version of this plugin are reported as MDLSITE-4432.
Thanks Markus. I removed both version records. Can you please send me the ZIP via e-mail? I will check the contents and it will help me to find the apparent bug in the Plugins directory. I have a suspicion but I want to be sure. The UI should not allow you to publish a ZIP if there are some unexpected issues with the layout of the files within the ZIP package. But it probably does and removes such files - which then leads to empty ZIPs.
You are right that we did not fix the PostgreSQL bug for the older 2.6 and 2.7 versions. I hided these together with the empty 2.8 versions. All of them can be removed, but I have no clue how to get the fixed version for Moodle 2.8 uploaded.
Markus Kemmerling
I can confirm that the ZIP released in the version https://moodle.org/plugins/pluginversion.php?id=9554 is empty. In fact, I am wondering how you actually managed to upload it as the validation raises critical error "[Important] The zip archive you uploaded did not contain any files" and I believed the plugins directory should not allow you to publish such version ...
With regards to your request to move this out of the incubator, I would first like to understand some things. Is the PostgreSQL failure fixed only in the version for Moodle 2.8? The old versions for Moodle 2.6 and 2.7 are still marked as available and I suspect they were not fixed, right? I don't mind if you decide to not backport the fix and support just Moodle 2.8 and higher. But in that case, we should hide or even completely remove those legacy versions.
I just uploaded a new version 2015-07-15 (02), which fixes the PostgreSQL error, the other two issues you reported on GitHub, and also as some issues we came across ourselves.
I am missing the button 'Schedule the plugin for re-approval', maybe because the plugin is in the 'Incubating' status. Could you please check the new version and move it (hopefully
Thanks,
Markus Kemmerling
Hi guys. Thanks for providing a new version of the plugin that fixes almost all of the issues reported above. Well done on that! I appreciate the overall level of the coding style and paying attention to the UI usability and various details in the code (such as fixing the
tool_customlangcontents on your string name fix.While checking the functionality, I discovered a malicious issue with some SQL queries that fail on PostgreSQL. See the report in your bug tracker with a suggested fix and details. As this issue makes the plugin fail badly on PostgreSQL, I moved the module temporarily to the Incubating category. Please let me know once a new version tested on PostgreSQL is available so that we can move the plugin into the proper category.
http://integration.moodle.org/job/Precheck%20remote%20branch/16047/artifact/work/smurf.html
We should have fixed all your issues for the newest 2.8.5 version which will be released during the next two months.
As soon as we are done we will use the link "Schedule the plugin for re-approval" and would be very happy if you could review it once again.
Screenshots have been already added.
Cheers Kasia
-Katarzyna Potocka-
administration of groups in Moodle. I am sure it will become very popular one
once that approved. That won't happen today though.
I noticed some classes (e.g. view_admin_form or view_import_form) in the global
PHP scope without the valid frankenstyle prefix. This is strongly discouraged
in order to prevent collisions with (current and/or future) core code or some
other plugin. See http://docs.moodle.org/dev/Coding_style#Functions_and_Methods
for details.
I noticed that your plugin is storing its settings in the mdl_config table
rather that the mdl_config_plugins. In order to avoid $CFG bloat and potential
collisions, it is recommended to use get_config to pull the data out of
mdl_config_plugins. The appropriate setting names should then be
grouptool/name_scheme instead of grouptool_name_scheme.
Please review English strings and check for missing spaces in place like "Show
groupmembers" (should read "Show group members").
The plugin fails on PostgreSQL databases due to missing fields in the SELECT
where GROUP BY is used. Leads to error like 'column "agrp.grpsize" must appear
in the GROUP BY clause or be used in an aggregate function' (see for example
http://rpbouman.blogspot.se/2007/05/debunking-group-by-myths.html for further
explanation).
Please add some good illustrative screenshots for this module.
While working on changes, you may also want to check the validation warnings
raised here in the plugins directory.
For now, I am going to mark this plugin as needing more work until we get these
issues resolved. Thanks for your patience with the review and approval process.