Outage manager

Hi Jeff,
Can you provide a little but more information so I can reproduce the problem?
I understand that your $CFG->wwwroot is 'http://10.0.0.1/moodle' but the redirection goes to 10.0.0.1/auth/outage/manage.php -- which gives you a NOT FOUND -- is that correct?
If not, are you using the outage autostart mode? If you are using autostart mode Moodle will not be accessible anymore until you manually finish the maintenance mode.
If you have a GitHub account you can open an issue in our repository at:
https://github.com/catalyst/moodle-auth_outage
Cheers,
Daniel

Hi there. Great plugin but there seems to be a few small issues. Admins cannot log onto Moodle when maintenance mode starts. This other one may be a configuration problem with my server if my website does 10.0.0.1/moodle and then I am redirected to the manage.php file within the plugin then i am sent to 10.0.0.1/auth/outage/manage.php

Hi David,
Can you please transfer the Lead Maintainer to 'Catalyst IT': https://moodle.org/user/profile.php?id=2153863
Cheers,
Daniel

I am happy to hear that, thanks David and Dan!

Prechecker results: 0 errors/0 warnings
https://integration.moodle.org/job/Precheck%20remote%20branch/28697/artifact/work/smurf.html

Hi Dan,
Thank you for the information, I've just submitted the changes as version 1.0.3.
Cheers,
Daniel

Hi Daniel,
thanks for working on this plugin, I can see it being really useful to manage scheduled outages in a more user-friendly manner. The code is documented nicely and follows Moodle coding guidelines well, also great to see the behat and phpunit tests. My one objection is the inclusion of the local_outage plugin within the code which doesn't seem to be required unless you are running an older version. The version uploaded here in the plugins db for newer versions definitely shouldn't include it, and the version for 2.8 should have it listed as a dependency in the version.php file. Once that is resolved I think it is ready for general release so that others can give further feedback on it.

Hi David, if its not done automatically, can you run again the checks in the version I submitted yesterday? Thanks.

Prechecker results: 43 errors/14 warnings
https://integration.moodle.org/job/Precheck%20remote%20branch/28123/artifact/work/smurf.html

Hi David,
Regarding the tests, you are right, $this->setExpectedException() is better and we can define which moment the exception should be thrown, which we cannot do with annotations.
That said PHPUnit is deprecating the $this->setExpectedException() and suggesting us to use $this->expectsException() instead. We can do that in Moodle 32 (master) but not before that. I decided to use the annotation to cover both cases.
I fixed them by creating a set_expected_exception which will adapt as needed, I just uploaded a new version with most of the issues fixed.
I am expecting a few " Class ) is not documented " messages but I believe this to be an issue with moodlecheck -- I created an issue at:
https://github.com/moodlehq/moodle-local_moodlecheck/issues/31
If you believe the notation with ::class I used is not good, I can revert to strings. I just think the error message from moodlecheck is complaining about an undocumented class, not that we should not use this notation.
Also, I expect a few invalid tag warning for unit tests, for example I use "@depends" to link test cases and a few "@SupressWarnings" for PHPMD in test cases (I don't see the why breaking testcases into more classes just to get PHPMD approval).
I am waiting for the report, once it I will post here and you can guide me if I should make any further changes.
Cheers,
Daniel

Hi. I will fix most of the issues, I am not sure why my moodle-plugin-ci check did not warn me before submitting.
In any case, there are a few problems such as:
https://git.in.moodle.com/mudrd8mz/moodle-plugins-snapshots/blob/63f61fb2ba21ff56c818249746a361409d34b6ea/auth/outage/tests/phpunit/local/controllers/infopage_test.php#L257
That are related to tests, if I use ' $this->expectException() ' I will probably get an deprecated warning. Is there any way to allow annotations?
I will comment again once I fixed most of the errors I can.
Thank you,
Daniel

Prechecker results: 301 errors/1 warnings
https://integration.moodle.org/job/Precheck%20remote%20branch/27871/artifact/work/smurf.html