Course feedback
Maintained by
Jan Eberhardt, Martin Gauk
This Block intends to give the system administrators a tool for forced evaluation of a course (or other facts). System administrators can define a set of textual questions, which can be rated from students.
Comments
Comments are no longer open for new posts. Existing comments remain available to read.
Aún no hay versión para moodle 3.0?
Gracias
if you have a github account, can you please open an issue at
https://github.com/eberhardt/moodle-block_coursefeedback/issues
Do you have any output from errors (enable debbuging at 'site preferences' -> 'development' -> 'debugging' with Level: Developer)?
Which character encoding do you use in your Browser? I recommend strongly to use UTF-8 as default character encoding.
If you open an issue, please answer the questions there.
Thx for your support
Jan
... i recently installed the course feedback for Moodle 2.8.3, but i met some problems here which is about the language i think.
Because my default language is zh_cn in my moodle, but when I configurate the question in the admin setting page, I can not add any questions into this language. But somehow, the language "en" is good to use, questions could be added into it.
And even I added some questions manually in mysql database. The whole system seems good to run, but at the final stage, when I view the results of the statistics, there are no data to display, but the frame and the table is there and seem right.
So, I am here for the help, thanks and look forward to hear from you.
Many thanks, good plugins.
No worries regarding tabs. We generally do not discriminate against plugins just because of not following the Moodle coding style. We try to encourage the dev community to follow the style for what we believe are good reasons. Even if I do not understand with your arguments (good editors have no problem with indentation regardless the actual usage of spaces or a tab), I do respect your choice.
I am not sure you understood the note about language pack. Nobody is expecting you would maintain another "different page". Strings provided by your plugin register at lang.moodle.org automatically (given the file uses expected syntax). My point was that both maintainers of the German and French language packs will eventually translate your plugin again, unless the existing strings are submitted there.
While re-testing the block, I noticed and reported a small issue into your issues tracker.
Said that, you are cleared to land now. Thanks for the patience with the review and approval process, and welcome to the Plugins directory. Good luck with further development and maintenance of this block.
1) I won't change my coding style in general. What means, I won't stop using tabs. It's easier to remove an indent with them.
2) I won't maintain a different page for translations. This block is to small for that effort.
Also a remark on the "problem" of `$succeeded > 0 && order_questions($feedbackid);`. This kind of code is used by in moodle core over and over (what's the difference to `defined('MOODLE_INTERNAL') || die();`?). If you are worried about readability, this should be an issue, as well.
* Unix type end-of lines (please check your editor settings)
* Closing PHP tags ?> at the end of files (it is recommended to avoid them)
* Overall coding style - please see https://docs.moodle.org/dev/Coding_style Parts like `$succeeded > 0 && order_questions($feedbackid);` only make the code less readable with no real benefit.
* Functions names - it is required to use the frankenstyle prefix to prevent eventual collisions - especially as you include your lib/lib.php from the main block file. Functions like `get_questions()` or `questions_exist()` or even `format()` can be easily understood as relating to other Moodle core components and/or plugins. Please either use the proper prefix, or encapsulate your functions as methods of a properly named class.
* The direct variable expansion in SQL queries - like used in e.g. `swap_questions()` - is strongly discouraged. I do appreciate attempts to properly clean up the variables (by explicit casting to int) but there should be no need to reinvent the wheel. I do not see a reason why these should not use the provided DB API and SQL placeholders (? or :named).
* Strings should be provided for the English only in the ZIP pack. All other translations should be uploaded to lang.moodle.org once the block is approved and published here.
* Neither concatenation operators nor other PHP code is supported in language packs. These files should be considered strictly data files. See https://github.com/eberhardt/moodle-block_coursefeedback/blob/master/lang/en/block_coursefeedback.php#L10 for an example of problematic place spotted during the review.
I am going to mark this as needing more work. Please schedule the plugin for re-approval once you manage to upload a new version that addresses these. Thanks for your patience with the review and approval process.
Have you had a look at this plugin recently? There are suggestions here to help publish this