Combined

Good morning! We updated our site to version 4.0.2 and unfortunately browsing the question bank causes the following error Unknown column 'q.category' in 'on clause'
SELECT q.*, qc.contextid FROM mdl_question q JOIN mdl_question_categories qc ON q.category = qc.id WHERE q.parent = ?
[array (
0 => '1991',
)]
Error code: dmlreadexception
Will there be a new version released that is compatible with Moodle version 4?
Many thanks

Yes. This is an issue with qtype_multichoiceset.
(This question type can be extended by other question types hooking into it. That is what qtype_multichoiceset is doing, so the issue is there, not here.)

Yes, this is about qtype_multichoiceset. (Btw, the current version of that plugin yields fatal errors when reviewing quiz/question attempts, see its bug tracker.)
Should I rather post this comment on the plugin's page?

@Florian. You're looking for https://moodle.org/plugins/qtype_multichoiceset in that case

Are you talking about qtype_multichoiceset?

First of all, thanks a lot for this great question type!
I would just like to point out that there is a small bug when it comes to showing the results of an allornothing question. While false positives are correctly marked with a red X, false negatives (i.e. empty checkboxes that should have been checked) are left unmarked. It is thus impossible for students to see why their answer did not receive any points.
Can you confirm this?

HI,
Please not the PHP and MySQL versions for the moodle 3.10 instance is running.
PHP Version 7.3.19
MariaDB version 10.3.25
Regards,
SJ

Hi Tim,
Last day i have upgraded my moodle from 3.7 to 3.10.
And from the combined essay type sub questions i am getting the following errors from the error log. [From the student role & Non-editing-teacher role]
[error] 14868#14868: *3617 FastCGI sent in stderr: "PHP message: Default exception handler: Exception - Access to undeclared static property: question_state::$ Debug:
Error code: generalexceptionmessage
* line 118 of /question/engine/states.php: Error thrown
* line 450 of /question/engine/questionattemptstep.php: call to question_state::get()
* line 1607 of /question/engine/questionattempt.php: call to question_attempt_step::load_from_records()
* line 960 of /question/engine/questionusage.php: call to question_attempt::load_from_records()
* line 481 of /question/engine/datalib.php: call to question_usage_by_activity::load_from_records()
* line 84 of /question/engine/lib.php: call to question_engine_data_mapper->load_questions_usage_by_activity()
* line 710 of /mod/quiz/attemptlib.php: call to question_engine::load_questions_usage_by_activity()
* line 648 of /mod/quiz/attemptlib.php: call to quiz_attempt->load_questions()
* line 669 of /mod/quiz/attemptlib.php: call to quiz_attempt->__construct()
* line 679 of /mod/quiz/attemptlib.php: call to quiz...
I know the combined 2.0 is not released for moodle 3.10 [sorry for not checking the docs before upgrade], is there anyway we can fix this error?
Best Regards,
SJ

It could be possible that this type of question could have a property for a "all or nothing" calification?

Wow!
What an expert!
It works, Tim!
Thanks for your profession and enthusiasm!
Best Regards,
FL
PS: Can you (or you know who can) help me to fix the problem in "https://moodle.org/mod/forum/discuss.php?d=402196"? Thanks.

OK, new version published. I hope that solves your problem.
Sorry for the inconvenience.

Oh! I think I see what has happened.
I got half way through checking that my plugins work with Moodle 3.9, which means that I have published the latest version of qtype_oumultiresponse, but not yet the latest qtype_combined.
And I did not realise that the new mutli-choice / old combined is a broken combination. I am working on pushing a new version now. I just need to get the automated tests to pass.

Hi Tim,
Thanks for your hint, and that is the full error message:
======
Debug info:
Error code: generalexceptionmessage
Stack trace:
line 74 of /question/type/oumultiresponse/combinable/combinable.php: Error thrown
line 85 of /question/type/combined/combiner/forform.php: call to qtype_combined_combinable_oumultiresponse->add_form_fragment()
line 68 of /question/type/combined/edit_combined_form.php: call to qtype_combined_combiner_for_form->form_for_subqs()
line 205 of /question/type/edit_question_form.php: call to qtype_combined_edit_form->definition_inner()
line 214 of /lib/formslib.php: call to question_edit_form->definition()
line 113 of /question/type/edit_question_form.php: call to moodleform->__construct()
line 47 of /question/type/combined/edit_combined_form.php: call to question_edit_form->__construct()
line 217 of /question/type/questiontypebase.php: call to qtype_combined_edit_form->__construct()
line 202 of /question/question.php: call to question_type->create_editing_form()
Output buffer: =======
Best Regards,
FL

That is a very surprising error message. qtype_multichoice is part of standard moodle!
Please can you turn on debugging (https://docs.moodle.org/en/Debugging) - set it to Developer level, and then copy the full error message. Then we can probably work out what the problem is. Thanks.

Hi Tim,
I think you are very busy, but I need your help.
I have effectively used your Combined plugin until now!
I receive the error message: "Exception - Class 'qtype_multichoice' not found " when creating a new combined question. I cannot preview the old combined questions! I tested with Moodle 3.9, 3.8, then 3.7, 3.6, 3.5 and I have the same problem!
I hope you help me to fix it!
Thanks.
Best Regards,
FL