Checkmark
Maintained by
AMC Academic Moodle Cooperation
In the checkmark activity, students announce in advance which of the given examples or tasks they have prepared for a classroom unit and can present if necessary. Teachers can assess students in the activity based on their ticks as well as on the actual presentation and also record attendance/absence.
Comments
Comments are no longer open for new posts. Existing comments remain available to read.
We should have fixed all your issues for the newest 2.8.5 version which will be released during the next two months.
As soon as we are done we will use the link "Schedule the plugin for re-approval" and would be very happy if you could review it once again.
Cheers Kasia
-Katarzyna Potocka-
Thanks a lot for sharing this plugin with the Moodle community. It's obvious there's a clear educational scenario behind the design
and modules like that are usually found very useful by teachers. I guess the UI might be made a bit more student-friendly and
intuitive yet but I know from my own experience that's not always easy to achieve. I will be happy to approve the plugin once couple
of found issues are fixed and a new version is provided.
I removed the legacy version as requested as set target Moodle versions for the new one as 2.6 and 2.7. Your module claims to
require Moodle 2013101800 at least which is some later 2.5+ version. You may wish to review this requirement and declare the Moodle
2.5.0 as the required version.
Please check the validation results (see the side Administration block for the link) and try to address those.
Please check the missing spaces in strings like 'Examplecount', 'Standardnames', 'Standardgrades' or 'Add Checkmarkinstance' in the
English language pack. They read too German for now
Please make sure to develop and test your code with full developer debugging on. I spotted "Warning: Creating default object from
empty value in mod/checkmark/locallib.php on line 884" which is trivial to fix. For this particular case, I prefer passing $a as an
associative array (no even need to cast to an object).
The PDF export fails badly on PostgreSQL databases with the following error: "ERROR: argument of WHERE must be type boolean, not
type integer". The correct SQL in the get_print_data() is `WHERE 1=1`, not just `WHERE 1`. The other trouble there is "ERROR: column
"s.id" must appear in the GROUP BY clause or be used in an aggregate function" which is a famous MySQLism. Please make sure your
plugin works with MySQL and PostgreSQL at least (the two most used DBs for Moodle installations).
As your @todo notes in the code suggest, you really should not access superglobals like $_POST directly. Moodle core provides
wrappers for good reasons. Please stick to them instead of inventing own ways of user input sanitization (that's more prone to error
and consequent security issue).
For now, I am leaving this in "Needs more work" status. Once a new version is uploaded (please make sure to select supported Moodle
versions, we are going to make that field mandatory soon anyway), use the link "Schedule the plugin for re-approval" in the
Administration block here so it gets back to our approval queue. Looking forward to hear from you soon!
Also, here were some of the issues the validation checker found:
Important In your version.php you have specified $module->requires = 2011120100, which is earlier than the official release of Moodle 2.2 (2011120500)
Warning The usage of $module in mod/xxx/version.php files was deprecated in Moodle 2.7. It is recommended to use the $plugin notation which has been supported since Moodle 2.6
Warning Maturity information ($module->maturity) not found in version.php
Lets start by making sure we have the versions correct and cleaning up some of these issues. For now, I am going to mark this plugin as needing more work until we get these issue resolved. Thanks for your patience with he review and approval process. Peace - Anthony
p.s. - Would you like a set created for the AMC plugins? This typically indicates that even if there are not strict dependencies that they tend to work best when installed together. If you do want a set, should we just say that these are all plugins shared by the Academic Moodle Cooperation?
The module shall be transfered to the user "academic-moodle-cooperation" - Profile url:
https://moodle.org/user/profile.php?id=1765078
Thanks in advance and best regards from Vienna
Andreas
Best regards - Andreas Hruska
this entry is currently unapproved.
Should we keep it here as currently being worked on, delete it or consider putting it into the "Others" category if it still doesn't conform to plugin standards?