Course Archiver
Maintained by
Matthew Davidson
Archive and remove past courses with this handy tool that can also be used to send notifications to course teachers, hide courses in bulk, and has the ability for course teachers to opt out of the archiving.
Comments
Comments are no longer open for new posts. Existing comments remain available to read.
Hi guys. CI bot prechecker is not executed automatically yet (but I hope it will be soon). In any case, thanks Matthew for the fixes, and thanks Rex for the peer-review. I am happy to approve this now. You are cleared to land, welcome to the Plugins directory!
http://integration.moodle.org/job/Precheck%20remote%20branch/18187/artifact/work/smurf.html
You can always run the code checkers yourself:
* https://moodle.org/plugins/view/local_codechecker
* https://moodle.org/plugins/view/local_moodlecheck
Otherwise, looks good to go.
Hi Matthew. I just encountered an issue with cross-db compatibility and reported it to your tracker. I'll mark the plugin as needing more work now to see if we can sort that out. Thanks for your patience with the review and approval process.
1) Your CSS styles in styles.css are too general. You have .error_text, .bar, and .progress_bar. These might have CSS style conflicts with other themes. So you might be affecting other areas of Moodle outside your own plugin. Consider namespacing your styles by prefixing your tool name in front of the style names.
2) Your LICENSE file says GPL2, but Moodle now uses GPL3.
3) For get_courses_and_their_owners(): https://github.com/Syxton/moodle-admin_coursearchiver/blob/master/classes/processor.php#L321 You are using a hard-coded roleid of 3. I am not sure which role you are looking for. Use role shortname or use role archetype, or have the roleid be a config setting. You are using the roleid of 3 in other areas as well.
http://integration.moodle.org/job/Precheck%20remote%20branch/17211/artifact/work/smurf.html