Course overview (legacy)

Hello Howard, and other Course Overview (Legacy) block users, we are joining our voice to Nathan Lind to express that this is also an important issue for us.
We will follow with attention the followups on this question.
Thank you,
Eric

Good day Howard, and other Course Overview (Legacy) block users. We love this block, and need its functionality until there is parity with the new Course Overview block. However, we have discovered an issue with the current version 3.5.0 of Course Overview (Legacy). The issue is when a faculty member turns editing mode on in their course, then goes back to the Dashboard, the links to their courses in the Course Overview (Legacy) block are no longer active. Nothing happens if the faculty clicks the name of a course. This used to work in our previous Moodle sites with older Legacy block. Might you have a fix for this, please?

Also add this after above fix (so that it gets precedence) :
@media screen and (max-width: 767px) {
.row.courseovbox.lead {
margin-left:0px;
}
}
Otherwise, favorite stars are cut off on the left under 767px width.

Add this to your Plugin, for all clean themes without bootstrap e.g. clean
/* FIX for non Bootstrap Themes */
.row.courseovbox.lead .col-sm-1 {
float: left;
width: 8.33333%;
}
.row.courseovbox.lead .col-sm-8 {
float: left;
width: 66.66667%;
}
.row.courseovbox.lead {
margin-left: -15px;
margin-right: -15px;
}

You can of course still download the earlier version. But I take your point and will split the plugin when I get a few minutes to do it.

I would like to respectfully repeat what Brian Warling said about this legacy block. As an institution, we choose to use the legacy block because we didn't want to have user interface changes.
I understand that there are people who are interested in the continual development of this block, and that having options can be a positive thing. I believe, however, that the legacy block should be kept as it was when Moodle 3.3 was announced, and a new fork created for this new block with these new features. Because that is what you are really doing, you are designing a new block with new features roughly based on the original.
The new modal blocks for assignments that need grading is awkward when you have long lists of assignments (>9) both because of the long list that goes beyond a single screen, but also because there is no spacing in between assignments. For our particular theme, the close X is the same color as the background.
Please consider undoing the most recent changes so that institutions can continue to use the old block until 3.7 as this was the original intention of this block, and creating a new block that you can create new features and develop.

Grrr... I think I might have done something stupid. I fixed it somewhere.... Investigating.

I totally agree with *everything* Jörgen explains. It's what i would have wrote, if my english was better.
And i still (with version 3.2.5 just out) have misalignments in Clean theme, with the left part of the stars and course titles cut (aligned too much left?).

...and, marking the the favourite in the course list is a very valid point. I'll get that sorted asap.

I just want to stress the importance of keeping the course in the course list after a course is made a favorite. This is important from a usability perspective. By making any item a favorite should not remove the item from a list that supposed to show all items. A clear example of this principle is the phone app in iOS. If you make some of your contacts a favorite does not remove the person from you contact list. If you in this case removes a course from the courses list because you made the course a favorite, you are forcing the user to always remember which courses are favorites and which are not. So, you would constantly be switching between the two lists. The longer the list of favorites become, the harder it will become to find that specific curse. 
A first step to fix this problem would be to make the default setting to keep favorites in the courses list as a default in the admin setting. I really think this is a much better default setting than "moving" the course to the favorites list. There should not be any surprises when the user makes a course a favorite (like Séverin Terrier describes in his post above). 
The feature to move a course from course list to the favorites list is such an odd behavior that it should be a user configuration and not a global configuration. Sorry if this sounds harsh, but I am just trying to make this plugin work for our users.

When a course is a favorite, the course should be marked as a favorite in the course list as well as in the favorites list. It is confusing for the user to have a course as a favorite (blue star) in the favorites list, but in the course list the same course is not marked as favorite (transparent star). Of course, this only applies if you have activated the setting to let the favorite courses remain in the course list. The reason to have the course marked as a favorite (blue star) in both lists is to present a consistent view of the items in the list. If a course is marked as a favorite it is a favorite regardless which tab the user looks in (favorites or courses). A nice feature would be if you then could un-mark the course as a favorite from both the favorites and the course view.

Keeping the course in the course list is now a (site-wide) option in the latest version.

I have made some small changes which make it look much better on the Clean theme. This is the latest code in Master. If you use it, remember to purge your caches as there is no version number change.

*V4 of course not V5

Hmmm.... that's odd. It should work fine. I'll have a look today.
On the subject of the Clean theme, do consider that it's on the list to be deprecated. the Bootstrapbase theme on which it is based uses an old/unsupported Bootstrap version. I should be able to make it work a bit better (the current versions of this plugin) but I'm reluctant to spend huge amounts of time on it. The current advise is to code new plugins against Bootstrap V5 (ass opposed to writing loads of CSS)