Quickmail
Maintained by
Robert Russo, David Lowe
A block that provides selective, bulk emailing within courses. Developed by LSU.
Comments
Comments are no longer open for new posts. Existing comments remain available to read.
The Bug
The code responsible for populating recipients when "All in Course" is selected has been commented out:
// Lines 222-227 - COMMENTED OUT (BUG)
// if ($this->check_course_msg()) {
// $this->populate_recip_course_msg();
// }
Technical Explanation
The Quickmail plugin uses two different approaches for recipient selection:
Role-based selection (e.g., "Students", "Teachers"): Recipients are stored directly in mdl_block_quickmail_msg_recips at compose time.
"All in Course" selection: The course ID is stored in mdl_block_quickmail_msg_course, with the intent to dynamically populate recipients at send time to account for enrollment changes.
The design intent for "All in Course" was:
At compose time: Store course ID in mdl_block_quickmail_msg_course
At send time: Call populate_recip_course_msg() to enumerate current enrollees
Proceed with sending to the populated recipient list
However, the code that triggers step 2 was commented out, so:
The course ID is stored correctly
Recipients are never populated
The message sends to zero recipients
No error is thrown because technically the send "succeeded"
we are using Quickmail with Moodle 4.5.2 and figured out that Quickmail does not behave as expected when writing an email and want to exclude e.g. special groups – the email will always be send to all members in the course. Did we miss anything or is this a bug?
Kathleen
Thank you very much.
Best regards.
Veronica.
Mais vous pouvez vous-même aller dans AMOS et terminer la traduction.
I changed the group setting from the default for the "block_quickmail_ferpa" setting to "Respect Course Mode" rather than the default "Always Separate Groups". This appears to have fixed the problem.
More information about this error
And also within the plugin overview it says:
v4.2.2 of quickmail
2024101701
any help ???
Send all scheduled Quickmail messages
\block_quickmail\tasks\send_all_ready_messages_task
Scheduled 10/30/24, 00:45:01 0.02 secs moodle 361031
9 reads
0 writes
Fail
Veiwing the failed log shows:
Execute scheduled task: Send all scheduled Quickmail messages (block_quickmail\tasks\send_all_ready_messages_task)
... started 00:45:01. Current memory use 21.0 MB.
Debugging increased temporarily due to faildelay of 61440
... used 9 dbqueries
... used 0.019463062286377 seconds
Scheduled task failed: Send all scheduled Quickmail messages (block_quickmail\tasks\send_all_ready_messages_task),groups_get_user_groups(): Argument #2 ($userid) must be of type int, null given, called in /mnt/data/moodle/blocks/quickmail/classes/repos/group_repo.php on line 92
Backtrace:
* line 92 of /blocks/quickmail/classes/repos/group_repo.php: call to groups_get_user_groups()
* line 66 of /blocks/quickmail/classes/repos/user_repo.php: call to block_quickmail\repos\group_repo::get_course_user_groups()
* line 335 of /blocks/quickmail/classes/repos/user_repo.php: call to block_quickmail\repos\user_repo::get_course_user_selectable_users()
* line 193 of /blocks/quickmail/classes/persistents/message.php: call to block_quickmail\repos\user_repo::get_unique_course_user_ids_from_selected_entities()
* line 222 of /blocks/quickmail/classes/repos/queued_repo.php: call to block_quickmail\persistents\message->populate_recip_course_msg()
* line 241 of /blocks/quickmail/classes/repos/queued_repo.php: call to block_quickmail\repos\queued_repo::sync_course_recip_msgs()
* line 49 of /blocks/quickmail/classes/tasks/send_all_ready_messages_task.php: call to block_quickmail\repos\queued_repo::get_all_messages_to_send()
* line 405 of /lib/classes/cron.php: call to block_quickmail\tasks\send_all_ready_messages_task->execute()
* line 208 of /lib/classes/cron.php: call to core\cron::run_inner_scheduled_task()
* line 125 of /lib/classes/cron.php: call to core\cron::run_scheduled_tasks()
* line 186 of /admin/cli/cron.php: call to core\cron::run_main_process()
I am running QM version v4.2.2
2024101701
on Moodle 4.38, build 20241011. I did not have this issue before updating QM and Moodle on 10/15/24. I just updated QM again, but that did not fix the issue.